[webkit-reviews] review granted: [Bug 112260] [Qt] Port DRT to use TestRunner::dumpAsText() : [Attachment 192928] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 112260: [Qt] Port DRT to use TestRunner::dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=112260

Attachment 192928: Patch
https://bugs.webkit.org/attachment.cgi?id=192928&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192928&action=review


Looks reasonable.

> Tools/ChangeLog:15
> +	       TestRunnerQt::shouldDumpPixels() always returned true
> +	       in our case and can therefore be replaced with
> +	       TestRunner::generatePixelResults().

I am a little confused by this sentence.