[webkit-reviews] review granted: [Bug 112225] Replace static_casts with to* functions for document types : [Attachment 192875] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Abhishek Arya
<inferno at chromium.org>'s request for review:
Bug 112225: Replace static_casts with to* functions for document types
https://bugs.webkit.org/show_bug.cgi?id=112225

Attachment 192875: Patch
https://bugs.webkit.org/attachment.cgi?id=192875&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192875&action=review


Please be sure to run tests by a debug build yourself before landing it.

> Source/WebCore/html/ImageDocument.h:88
> +// This will catch anyone doing an unnecessary cast.
> +void toImageDocument(const ImageDocument*);

I'm not sure if this is really useful.

> Source/WebCore/html/MediaDocument.h:71
> +// This will catch anyone doing an unnecessary cast.
> +void toMediaDocument(const MediaDocument*);

Ditto.