[webkit-reviews] review denied: [Bug 108425] [Qt] Change the way of determining whether build-webkit needs full incremental build : [Attachment 185675] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 13 10:11:52 PDT 2013
Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Seulgi Kim
<seulgikim at company100.net>'s request for review:
Bug 108425: [Qt] Change the way of determining whether build-webkit needs full
incremental build
https://bugs.webkit.org/show_bug.cgi?id=108425
Attachment 185675: Patch
https://bugs.webkit.org/attachment.cgi?id=185675&action=review
------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
No need to duplicate this code, plus the file should be saved in every case,
including the two "elsif" above.
You could just move this code out of "if ($result eq 0)" and run it right after
we ran "system $command".
More information about the webkit-reviews
mailing list