[webkit-reviews] review denied: [Bug 111360] After sending message, Mail changes formatting : [Attachment 192160] Also prevent nested h1-h6

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 111360: After sending message, Mail changes formatting
https://bugs.webkit.org/show_bug.cgi?id=111360

Attachment 192160: Also prevent nested h1-h6
https://bugs.webkit.org/attachment.cgi?id=192160&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192160&action=review


Please do

> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:462
> +    DEFINE_STATIC_LOCAL(HashSet<AtomicString>, elements, ());

Please do not add static state to the tree builder.  It's likely we'll want to
move it onto a background thread at some point, and we can't have static state
on a background thread.

> Source/WebCore/html/parser/HTMLTreeBuilder.h:92
> +    static bool isProhibitedParagraphChild(const AtomicString&);

I'd wrap this in an #ifndef NDEBUG to make it clear that it's a debug-only
function.