[webkit-reviews] review requested: [Bug 111879] Don't use bash constructs in Source/autotools/FindDependencies.m4 : [Attachment 192255] Use a="$a foo" to append instead of using a+=" foo"
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 8 11:25:55 PST 2013
Landry Breuil <landry at openbsd.org> has asked for review:
Bug 111879: Don't use bash constructs in Source/autotools/FindDependencies.m4
https://bugs.webkit.org/show_bug.cgi?id=111879
Attachment 192255: Use a="$a foo" to append instead of using a+=" foo"
https://bugs.webkit.org/attachment.cgi?id=192255&action=review
------- Additional Comments from Landry Breuil <landry at openbsd.org>
https://bugs.webkit.org/show_bug.cgi?id=109246 splitted stuff from configure.ac
to Source/autotools.
As it is now, it doesnt build on hosts where sh is not bash, because it uses
a+="foo" constructs which are not valid in posix shells.
$a+="bar"
ksh: a+=bar: not found
More information about the webkit-reviews
mailing list