[webkit-reviews] review granted: [Bug 111783] DFG should not get corrupted IR in the case of code that is dead, unreachable, and contains a chain of nodes that use each other in an untyped way : [Attachment 192097] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 111783: DFG should not get corrupted IR in the case of code that is dead,
unreachable, and contains a chain of nodes that use each other in an untyped
way
https://bugs.webkit.org/show_bug.cgi?id=111783

Attachment 192097: the patch
https://bugs.webkit.org/attachment.cgi?id=192097&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=192097&action=review


r=me

> Source/JavaScriptCore/dfg/DFGDCEPhase.cpp:162
> +	       if (edge.needsCheck() && edge.useKind() != UntypedUse)

Make this clearer like we discussed.