[webkit-reviews] review granted: [Bug 111772] CFNetwork cache partitioning does not work properly on subdomains : [Attachment 192082] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Jeffrey Pfau
<jeffrey at endrift.com>'s request for review:
Bug 111772: CFNetwork cache partitioning does not work properly on subdomains
https://bugs.webkit.org/show_bug.cgi?id=111772

Attachment 192082: Patch
https://bugs.webkit.org/attachment.cgi?id=192082&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192082&action=review


r=me

> Source/WebCore/platform/network/mac/ResourceRequestMac.mm:193
> +    String partition = cachePartition();
> +    if (!partition.isNull() && !partition.isEmpty())
> +	   [NSURLProtocol setProperty:[NSString
stringWithUTF8String:partition.utf8().data()] forKey:(NSString
*)wkCachePartitionKey() inRequest:nsRequest];

This would be easier to read if you pulled out the UTF-8 string conversion as a
separate local variable:

	NSString *partitionValue = [NSString
stringWithUTF8String:partition.utf8().data()];
	[NSURLProtocol setProperty:partitionValue forKey:(NSString
*)wkCachePartitionKey() inRequest:nsRequest];