[webkit-reviews] review requested: [Bug 111375] [v8] Binding integrity non-functional on windows : [Attachment 191360] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 17:33:39 PST 2013


Kentaro Hara <haraken at chromium.org> has asked  for review:
Bug 111375: [v8] Binding integrity non-functional on windows
https://bugs.webkit.org/show_bug.cgi?id=111375

Attachment 191360: Patch.
https://bugs.webkit.org/attachment.cgi?id=191360&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191360&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3717
> +sub GetWinMangledExtensionForType

This looks really fragile. Wouldn't there be any alternative idea to avoid
hard-coding?


More information about the webkit-reviews mailing list