[webkit-reviews] review denied: [Bug 111375] [v8] Binding integrity non-functional on windows : [Attachment 191360] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 17:33:24 PST 2013


Adam Barth <abarth at webkit.org> has denied Thomas Sepez <tsepez at chromium.org>'s
request for review:
Bug 111375: [v8] Binding integrity non-functional on windows
https://bugs.webkit.org/show_bug.cgi?id=111375

Attachment 191360: Patch.
https://bugs.webkit.org/attachment.cgi?id=191360&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191360&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3722
> +    return "ActiveDOMObject\@1\@" if ($typename eq "AbstractWorker");
> +    return "ActiveDOMObject\@1\@" if ($typename eq "AudioContext");

We don't want to special-case all these interfaces in the code generator.


More information about the webkit-reviews mailing list