[webkit-reviews] review granted: [Bug 90341] createAttribute/setAttributeNode does not properly normalize case : [Attachment 191103] Slightly tweaked layout test patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 90341: createAttribute/setAttributeNode does not properly normalize case
https://bugs.webkit.org/show_bug.cgi?id=90341

Attachment 191103: Slightly tweaked layout test patch
https://bugs.webkit.org/attachment.cgi?id=191103&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191103&action=review


> Source/WebCore/dom/Element.cpp:1727
> +    const QualifiedName& caseAdjustedName = shouldIgnoreAttributeCase(this)
? QualifiedName(attrName.prefix(), attrName.localName().lower(),
attrName.namespaceURI()) : attrName;

If this was performance critical, we could have a more-optimal case for the
case where attrName.localName() is already all lowercase that avoids a hash
table lookup to create a new QualifiedName in that case. But the entire
Attr-related API is intrinsically slow already, so that seems like an unneeded
micro-optimization.