[webkit-reviews] review granted: [Bug 111258] PDFPlugin: Rename delegate method from openWithPreview to openWithNativeApplication : [Attachment 191121] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 111258: PDFPlugin: Rename delegate method from openWithPreview to
openWithNativeApplication
https://bugs.webkit.org/show_bug.cgi?id=111258

Attachment 191121: patch
https://bugs.webkit.org/attachment.cgi?id=191121&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191121&action=review


r=me assuming there is a good answer to the question below.

> Source/WebKit2/ChangeLog:11
> +	   Rename from openWithPreview to openWithNativeApplication for
accuracy.

I don't understand this explanation. The delegate name should match what
PDFLayerController expects, even if we find that inaccurate.

Did PDFLayerController change? If it did, do we need to support both names for
the time being?