[webkit-reviews] review denied: [Bug 117868] Texture unit code refactoring : [Attachment 205172] Texture unit code refactoring

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Przemyslaw Szymanski
<p.szymanski3 at samsung.com>'s request for review:
Bug 117868: Texture unit code refactoring
https://bugs.webkit.org/show_bug.cgi?id=117868

Attachment 205172: Texture unit code refactoring
https://bugs.webkit.org/attachment.cgi?id=205172&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205172&action=review


R- due to missing changelog.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:-612
> -	 m_textureUnits[i].m_texture2DBinding = 0;

4 spaces for indent please

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4811
> +	       const GC3Denum target =
m_textureUnits[ii].m_textureBinding->getTarget();

We don't use local const in webkit.