[webkit-reviews] review granted: [Bug 118055] [GTK] [WK2] Check value of WEBKIT_INJECTED_BUNDLE_PATH : [Attachment 205477] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Alberto Garcia
<agarcia at igalia.com>'s request for review:
Bug 118055: [GTK] [WK2] Check value of WEBKIT_INJECTED_BUNDLE_PATH
https://bugs.webkit.org/show_bug.cgi?id=118055

Attachment 205477: Patch
https://bugs.webkit.org/attachment.cgi?id=205477&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
I think providing an invalid directory in WEBKIT_INJECTED_BUNDLE_PATH is an
error of the one who set the variable. This env var is only useful for internal
tests and tools, users of the WebKit2GTK+ API should use web extensions
instead. So, I'm not sure it's a good idea to add a blocking I/O call here. On
the other hand, the check is only done when the env var contains something
(this shouldn't happen in most of the cases), so I guess it's harmless. I
wonder whether we should return NULL and/or print an error in stderr in that
case instead of falling back to system directory. It can be very confusing if I
make a typographic error and the installed injected bundle is used silently.
What do you think?