[webkit-reviews] review granted: [Bug 117853] WebGL files not included in Windows build (take 2) : [Attachment 205129] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 21 09:53:35 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 117853: WebGL files not included in Windows build (take 2)
https://bugs.webkit.org/show_bug.cgi?id=117853

Attachment 205129: Patch
https://bugs.webkit.org/attachment.cgi?id=205129&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205129&action=review


Looks good.  I'm going to try building it locally.

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:148
> +    <ClCompile
Include="$(ConfigurationBuildDir)\obj32\WebCore\DerivedSources\JSEXTDrawBuffers
.cpp">

I hate how Visual Studio creates all this solution/project file churn.


More information about the webkit-reviews mailing list