[webkit-reviews] review denied: [Bug 117294] [WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010. : [Attachment 205171] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 21 09:49:29 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has denied peavo at outlook.com's request for
review:
Bug 117294: [WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.
https://bugs.webkit.org/show_bug.cgi?id=117294

Attachment 205171: Patch
https://bugs.webkit.org/attachment.cgi?id=205171&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205171&action=review


I don't think this patch is quite right.  The SchedulePair header and
implementations both refer to CoreFoundation types.  It may be that you can
build without CoreFoundation in cases where the underlying code using these
headers do not happen to call code that actually needs access to CoreFoundation
symbols, but this really isn't right as some seemingly unrelated future change
could suddenly cause the build to break.

Instead, we need to make Debug_WinCairo and Release_WinCairo targets for WTF
that link to CFLite.lib instead of CoreFoundation.lib so that the calls to
CFEqual and use of various CF types will resolve to real symbols at link time.

> Source/WTF/WTF.vcxproj/WTFCommon.props:26
> +	
<AdditionalDependencies>winmm.lib;libicuuc$(DebugSuffix).lib;libicuin$(DebugSuf
fix).lib;%(AdditionalDependencies)</AdditionalDependencies>

While it is good to remove the CoreFoundation.lib dependency here, we should be
using CFLite on the WinCairo build.

> Source/WTF/WTF.vcxproj/WTFDebug.props:15
> +    </Link>

This property sheet still requires CoreFoundation.lib for WinCairo builds.


More information about the webkit-reviews mailing list