[webkit-reviews] review canceled: [Bug 117711] [CMake][CSS Shaders] Conditionally add WebCore files for CSS Shaders to CMakeLists.txt : [Attachment 204845] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 18 08:21:13 PDT 2013


Ralph T <ralpht+bugs at gmail.com> has canceled Ralph T <ralpht+bugs at gmail.com>'s
request for review:
Bug 117711: [CMake][CSS Shaders] Conditionally add WebCore files for CSS
Shaders to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=117711

Attachment 204845: Patch
https://bugs.webkit.org/attachment.cgi?id=204845&action=review

------- Additional Comments from Ralph T <ralpht+bugs at gmail.com>
Since all of the files included are guarded with #if ENABLE(CSS_SHADERS) I can
just add them to WebCore_SOURCES unconditionally -- I'll submit a new patch
that does this later today. Thanks to Patrick Gansterer and Raphael Kubo da
Costa for review.


More information about the webkit-reviews mailing list