[webkit-reviews] review denied: [Bug 117736] [GStreamer] Potential race condition when getting the video sink caps. : [Attachment 204913] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Víctor M. Jáquez L.
<vjaquez at igalia.com>'s request for review:
Bug 117736: [GStreamer] Potential race condition when getting the video sink
caps.
https://bugs.webkit.org/show_bug.cgi?id=117736

Attachment 204913: Patch
https://bugs.webkit.org/attachment.cgi?id=204913&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204913&action=review


Ok, just a couple of nitpicks:

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:302
> +static void webkitVideoSinkGetProperty(GObject *object, guint propId, GValue
*value, GParamSpec *pspec)

The stars are misplaced, we also prefer to use longer names, like propertyId
and parameterSpec

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:492
> +    GstCaps* currentCaps;

Please move this just before the g_object_get() call