[webkit-reviews] review denied: [Bug 117667] Expose the mediaIsVideo method in WebKit : [Attachment 204752] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Ruth Fong <ruthiecftg at gmail.com>'s
request for review:
Bug 117667: Expose the mediaIsVideo method in WebKit
https://bugs.webkit.org/show_bug.cgi?id=117667

Attachment 204752: Patch
https://bugs.webkit.org/attachment.cgi?id=204752&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Style seems fine here, but I'm not convinced this API is the way to go.

Asking a WKBundleHitTestResult if the media is video for a non-media element is
kind of weird.	Of course it's not video - It's a div, or a img!

The client would have to first determine that the hit test result represents a
media element by getting the media src URL (which is kind of a weird way to
determine that...) and then use this API.

The new API should probably be a general purpose "what kind of media element is
this?" call.  To start with it could return:
kWKMediaTypeAudio
kWKMediaTypeVideo
kWKMediaTypeNone

This removes some burden on the client and is also expandable in the future
when we add <smell>, <taste>, or <touch>.