[webkit-reviews] review granted: [Bug 117706] AX: display: -webkit-box formatted <li> elements are not assigned correct accessibility roles : [Attachment 204842] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 117706: AX: display: -webkit-box formatted <li> elements are not assigned
correct accessibility roles
https://bugs.webkit.org/show_bug.cgi?id=117706

Attachment 204842: Patch
https://bugs.webkit.org/attachment.cgi?id=204842&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204842&action=review


looking good. i would suggest updating the layout test to make it more
specific.

> LayoutTests/accessibility/box-styled-lists.html:46
> +	       var bodyElement = document.getElementById("body");

I try to avoid the attributesofChildren() method these days because it's not
very specific if something breaks.

For this test I would probably do

var listItem = document.accessibleElementById("test 1");
shouldBe("listeItem.role", "'AXRole: AX...'");