[webkit-reviews] review granted: [Bug 117390] Introducing StackIterator class. : [Attachment 204274] patch #3

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 117390: Introducing StackIterator class.
https://bugs.webkit.org/show_bug.cgi?id=117390

Attachment 204274: patch #3
https://bugs.webkit.org/attachment.cgi?id=204274&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204274&action=review


r=me

> Source/JavaScriptCore/interpreter/CallFrame.h:280
> +	   JS_EXPORT_PRIVATE StackIterator beginAt(JSFunction*
calleeFunctionObj, StackIterator::FrameFilter = nullptr);

In idiomatic C++, a function that finds a location in a list and returns an
iterator is named "find".

Since our plan is to switch to a callback style and remove this interface soon,
I guess it's OK to be expedient leave this as-is for now.