[webkit-reviews] review denied: [Bug 117405] [EFL]Background Style of element not visible because of default theme style : [Attachment 204155] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 117405: [EFL]Background Style of element not visible because of  default
theme style
https://bugs.webkit.org/show_bug.cgi?id=117405

Attachment 204155: Patch
https://bugs.webkit.org/attachment.cgi?id=204155&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204155&action=review


> Source/WebCore/ChangeLog:7
> +

Missing patch description.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:-29
> -

Do not touch unrelated this patch.

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:892
> +    bool success = paintMenuList(object, info, rect);

Could you explain why paintMenuList() should be called first ?

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:898
> +	   IntPoint pnt1(maxX - 1 - 15, centerYOfRect - 3);

This logic looks like work-around-ish.