[webkit-reviews] review granted: [Bug 117162] [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code : [Attachment 204176] Updated, incorporating feedback

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Bear Travis
<betravis at adobe.com>'s request for review:
Bug 117162: [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes
code
https://bugs.webkit.org/show_bug.cgi?id=117162

Attachment 204176: Updated, incorporating feedback
https://bugs.webkit.org/attachment.cgi?id=204176&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204176&action=review


r=me

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:118
> +	   ShapeInsideInfo* shapeInsideInfo = m_block->layoutShapeInsideInfo();

> +	   if (shapeInsideInfo)

nit: The variable could live inside the condition statement. That's more like
the WebKit style.

> Tools/ChangeLog:8
> +	   Adding the rendering/shapes directory

nit: It looks like you forgot to finish the sentence in the WebKit project
Changelogs. "Adding the webcore/rendering/shapes directory to the include
list."