[webkit-reviews] review granted: [Bug 117416] [WK2][CoordinatedGraphics] Add default case to switches to fix strict build : [Attachment 204180] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Sergio Correia
<sergio.correia at openbossa.org>'s request for review:
Bug 117416: [WK2][CoordinatedGraphics] Add default case to switches to fix
strict build
https://bugs.webkit.org/show_bug.cgi?id=117416

Attachment 204180: Patch
https://bugs.webkit.org/attachment.cgi?id=204180&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204180&action=review


> Source/WebKit2/ChangeLog:26
> +	   While doing a strict build, with ENABLE_WERROR enabled, gcc
complained
> +	   about some enumeration values not being handled in two switch
statements,
> +	   causing the build to fail:
> +
> +	   CoordinatedGraphicsArgumentCoders.cpp:171:24: error: enumeration
value
> +	   'COLOR' not handled in switch [-Werror=switch]
> +	   CoordinatedGraphicsArgumentCoders.cpp:171:24: error: enumeration
value
> +	   'MATRIX' not handled in switch [-Werror=switch]
> +
> +	   and
> +
> +	   CoordinatedGraphicsArgumentCoders.cpp:288:24: error: enumeration
value
> +	   'COLOR' not handled in switch [-Werror=switch]
> +	   CoordinatedGraphicsArgumentCoders.cpp:288:24: error: enumeration
value
> +	   'MATRIX' not handled in switch [-Werror=switch]
> +	   cc1plus: all warnings being treated as errors
> +
> +	   This patch adds a default case for each of these switches, to stop
gcc
> +	   from complaining and breaking a strict build.

Too much information, simply say that you fix strict build by asserting on
default switch cases or something like that :)