[webkit-reviews] review granted: [Bug 116717] [GTK] Do not use X11 WidgetBackingStore implementation in Wayland : [Attachment 203335] Fixed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Iago Toral
<itoral at igalia.com>'s request for review:
Bug 116717: [GTK] Do not use X11 WidgetBackingStore implementation  in Wayland
https://bugs.webkit.org/show_bug.cgi?id=116717

Attachment 203335: Fixed patch
https://bugs.webkit.org/attachment.cgi?id=203335&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203335&action=review


Looks good, but I have a few style nits.

> Source/WebCore/platform/gtk/GtkWidgetBackingStoreX11.cpp:47
> +    m_pixmap = XCreatePixmap(m_display,
> +	   GDK_WINDOW_XID(gdk_screen_get_root_window(screen)),
> +	   size.width(), size.height(),
> +	   gdk_visual_get_depth(visual));

This statement would be short enough to put all the arguments on one line.

> Source/WebKit2/UIProcess/cairo/BackingStoreCairo.cpp:33
> +#if PLATFORM(GTK) && defined(GDK_WINDOWING_X11)
> +#include <WebCore/GtkWidgetBackingStoreX11.h>
> +#include <gdk/gdkx.h>
> +#endif

This block should go after the main one separated by a blank line.

> Source/WebKit2/UIProcess/cairo/BackingStoreCairo.cpp:50
> +static OwnPtr<WidgetBackingStore> createBackingStore(GtkWidget* widget,
const IntSize& size)

Maybe this can be called createBackingStoreForGTK.

> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:80
> +#ifdef GDK_WINDOWING_X11
> +#define Font XFont
> +#define Cursor XCursor
> +#define Region XRegion
> +#include <gdk/gdkx.h>
> +#undef Font
> +#undef Cursor
> +#undef Region
> +#undef None
> +#undef Status
> +#endif

Again, this block should go after the main one and separated by a newline.