[webkit-reviews] review denied: [Bug 117265] Spatial Navigation should avoid unwanted calculation while deciding focus candidate. : [Attachment 203905] 117265.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 6 06:42:12 PDT 2013


Antonio Gomes <tonikitoo at webkit.org> has denied Abhijeet Kandalkar
<kandalkar.abhijeet58 at gmail.com>'s request for review:
Bug 117265: Spatial Navigation should avoid unwanted calculation while deciding
focus candidate.
https://bugs.webkit.org/show_bug.cgi?id=117265

Attachment 203905: 117265.patch 
https://bugs.webkit.org/attachment.cgi?id=203905&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203905&action=review


we can test it with "Internals" interface: for example, as per target
calculation, expose a counter that holds how many target nodes were tested
before having a final target.

> page/SpatialNavigation.cpp:630
> +	       result = true;

just return true right way.


More information about the webkit-reviews mailing list