[webkit-reviews] review requested: [Bug 115406] [GTK] Use drawErrorUnderline() instead of Pango API for highlighting misspelled words : [Attachment 203603] last patch removing the cairo_new_path(), which was not required

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 3 09:39:40 PDT 2013


Eduardo Lima Mitev <elima at igalia.com> has asked  for review:
Bug 115406: [GTK] Use drawErrorUnderline() instead of Pango API for
highlighting misspelled words
https://bugs.webkit.org/show_bug.cgi?id=115406

Attachment 203603: last patch removing the cairo_new_path(), which was not
required
https://bugs.webkit.org/attachment.cgi?id=203603&action=review

------- Additional Comments from Eduardo Lima Mitev <elima at igalia.com>
After discussing a bit with mrobinson, I learned that it should not be required
to cairo_new_path() at the beginning of drawErrorUnderline(). These routines
should assume and respect a clean path.

This new patch just removes the call to cairo_new_path() in
drawErrorUnderline(), and just add the cairo_fill() at the end.

Tests are passing and all looks ok to me.


More information about the webkit-reviews mailing list