[webkit-reviews] review canceled: [Bug 115406] [GTK] Use drawErrorUnderline() instead of Pango API for highlighting misspelled words : [Attachment 203567] updated patch including new baseline PNGs

[bugzilla-daemon at webkit.org]

Eduardo Lima Mitev <elima at igalia.com> has canceled Eduardo Lima Mitev
<elima at igalia.com>'s request for review:
Bug 115406: [GTK] Use drawErrorUnderline() instead of Pango API for
highlighting misspelled words
https://bugs.webkit.org/show_bug.cgi?id=115406

Attachment 203567: updated patch including new baseline PNGs
https://bugs.webkit.org/attachment.cgi?id=203567&action=review

------- Additional Comments from Eduardo Lima Mitev <elima at igalia.com>
After discussing a bit with mrobinson, I learned that it should not be required
to cairo_new_path() at the beginning of drawErrorUnderline(). These routines
should assume and respect a clean path.

This new patch just removes the call to cairo_new_path() in
drawErrorUnderline(), and just add the cairo_fill() at the end.

Tests are passing and all looks ok to me.