[webkit-reviews] review denied: [Bug 33226] Indent inside li with br's changes order and creates new lists : [Attachment 207690] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Sudarshan C P
<cp.sudarshan at gmail.com>'s request for review:
Bug 33226: Indent inside li with br's changes order and creates new lists
https://bugs.webkit.org/show_bug.cgi?id=33226

Attachment 207690: Patch
https://bugs.webkit.org/attachment.cgi?id=207690&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207690&action=review


review- because this seems to have a bad cast in it and because there is no
test case; we require test cases for WebKit bug fixes.

> Source/WebCore/editing/IndentOutdentCommand.cpp:73
> +    Element* currentElement =
static_cast<Element*>(lastNodeInSelectedParagraph);

Should use toElement. But what guarantees this is an element, not a non-element
node?