[webkit-reviews] review granted: [Bug 119237] Content filter replacement data uses the encoding from the blocked page's response headers : [Attachment 207700] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 119237: Content filter replacement data uses the encoding from the blocked
page's response headers
https://bugs.webkit.org/show_bug.cgi?id=119237

Attachment 207700: Patch
https://bugs.webkit.org/attachment.cgi?id=207700&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207700&action=review


r=me but please consider Alexey’s question

> Source/WebCore/loader/DocumentLoader.cpp:807
> +	   // The content filter's replacement data has a known encoding.
Ignore
> +	   // both the override encoding and the blocked response's encoding.
> +	   if (m_loadWasBlockedByContentFiltering) {
> +	       userChosen = false;
> +	       encoding = String();
> +	   }

It’s a little awkward to compute and then ignore userChosen and encoding. Would
be nice to structure the code so they were not even computed.