[webkit-reviews] review granted: [Bug 118918] Eager stack trace for error objects. : [Attachment 207671] patch 7

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Curtis
<chris_curtis at apple.com>'s request for review:
Bug 118918: Eager stack trace for error objects.
https://bugs.webkit.org/show_bug.cgi?id=118918

Attachment 207671: patch 7
https://bugs.webkit.org/attachment.cgi?id=207671&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207671&action=review


r=me

> Source/JavaScriptCore/interpreter/Interpreter.cpp:571
> +    JSGlobalObject* globalObject = 0;
>  
> +    if (error) {
> +	   if (isTerminatedExecutionException(*error))
> +	       globalObject = vm->dynamicGlobalObject;
> +	   else
> +	       globalObject = asObject(*error)->globalObject();
> +    } else
> +	   globalObject = vm->dynamicGlobalObject;

Sorry, I should have been clearer here: now that you've threaded "exec" into
this function, you can remove all this code. This code is only used to produce
globalObject->globalExec(). You can use "exec" instead, and delete this code.

Please fix this in a follow-up patch.

> Source/JavaScriptCore/interpreter/Interpreter.cpp:590
> -	   if (asObject(error)->hasProperty(callFrame,
vm->propertyNames->stack))
> +    if (vm->exceptionStack().size()) {
> +	   if (!error.isObject() || asObject(error)->hasProperty(callFrame,
vm->propertyNames->stack))
>	       return;

Please file a follow-up bug about the ASSERT you saw firing in this case.