[webkit-reviews] review granted: [Bug 119228] TextTrackRepresentation captions often disappear then appear again. : [Attachment 207677] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 119228: TextTrackRepresentation captions often disappear then appear again.
https://bugs.webkit.org/show_bug.cgi?id=119228

Attachment 207677: Patch
https://bugs.webkit.org/attachment.cgi?id=207677&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207677&action=review


> Source/WebCore/html/HTMLMediaElement.h:294
> +    enum ConfigureTextTrackDisplayFlags {
DoNotAssumeVisibleTextTracksChanged, AssumeVisibleTextTracksChanged };

"Flags" make me think this is a bitmask, and then the "flags ==
DoNotAssumeVisibleTextTracksChanged" code seemed iffy. Not sure I like
"AssumeVisibleTextTracksChanged" etc; can you change the name to something more
descriptive of the impact?