[webkit-reviews] review requested: [Bug 118996] [Windows] Parser asserts because sourceOffset != UINT_MAX : [Attachment 207334] the patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 118996: [Windows] Parser asserts because sourceOffset != UINT_MAX
https://bugs.webkit.org/show_bug.cgi?id=118996

Attachment 207334: the patch
https://bugs.webkit.org/attachment.cgi?id=207334&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
This bug reports an assertion regarding the value of the sourceOffset field in
JSTokenLocation.  Conveniently, that field is no longer needed.  So, we can
simply remove it and clean up the code, thereby also removing the assert (which
is now moot).

Some background history regarding the sourceOffset field in JSTokenLocation:

The JSTokenLocation sourceOffset field was added in
http://trac.webkit.org/changeset/152494 to support some transitional code while
that change was being developed.  When all the dust settled, the sourceOffset
field was no longer needed (as evident by the fact that the JSTokenLocation
"position" methods are not called from anywhere).  The sourceOffset field and
associated artifacts should have been removed.

This patch cleans that up.  The patch builds cleanly against trunk r152583 and
passes all the javascriptcore tests and relevant layout tests.	Will commence
with running the full layout tests after this.	The patch is ready for review.