[webkit-reviews] review denied: [Bug 100379] [Win] WebView didReceiveIcon delegate call doesn't have the icon in it : [Attachment 204703] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 23 09:52:09 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has denied peavo at outlook.com's request for
review:
Bug 100379: [Win] WebView didReceiveIcon delegate call doesn't have the icon in
it
https://bugs.webkit.org/show_bug.cgi?id=100379

Attachment 204703: Patch
https://bugs.webkit.org/attachment.cgi?id=204703&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=204703&action=review


Sorry -- I didn't notice that we would have to cast that sz variable from
IntSize to SIZE. Please correct that and I'll r+ it (today!)

> Source/WebKit/win/WebView.cpp:2882
> +	       icon->getHBITMAPOfSize(hBitmap, &(SIZE)sz);

This should be written as "&static_cast<SIZE>(sz)"


More information about the webkit-reviews mailing list