[webkit-reviews] review denied: [Bug 118970] [Web Inspector] When right-clicking on a DataGrid column, show editing menu option as "Edit <columnName>" instead of just "Edit" : [Attachment 207247] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 22 08:00:23 PDT 2013
Timothy Hatcher <timothy at apple.com> has denied review:
Bug 118970: [Web Inspector] When right-clicking on a DataGrid column, show
editing menu option as "Edit <columnName>" instead of just "Edit"
https://bugs.webkit.org/show_bug.cgi?id=118970
Attachment 207247: Patch
https://bugs.webkit.org/attachment.cgi?id=207247&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207247&action=review
> Source/WebInspectorUI/ChangeLog:9
> + * Localizations/en.lproj/localizedStrings.js: Add literal "Edit
'%s'"
If you didn't, you should use the update-webkit-localized-strings script, which
will update this file for you.
> Source/WebInspectorUI/UserInterface/DataGrid.js:1128
> + contextMenu.appendItem(WebInspector.UIString("Edit
'%s'").format(columnTitle), this._startEditing.bind(this, event.target));
This should use double curly quotes (“”) and not single quotes.
More information about the webkit-reviews
mailing list