[webkit-reviews] review granted: [Bug 118970] [Web Inspector] When right-clicking on a DataGrid column, show editing menu option as "Edit <columnName>" instead of just "Edit" : [Attachment 207247] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at apple.com> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 118970: [Web Inspector] When right-clicking on a DataGrid column, show
editing menu option as "Edit <columnName>" instead of just "Edit"
https://bugs.webkit.org/show_bug.cgi?id=118970

Attachment 207247: Patch
https://bugs.webkit.org/attachment.cgi?id=207247&action=review

------- Additional Comments from Antoine Quint <graouts at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207247&action=review


> Source/WebInspectorUI/UserInterface/DataGrid.js:1111
> +	   function getColumnIdentifier(node) {
> +	       var element = node.enclosingNodeOrSelfWithNodeName("td");
> +	       return parseInt(element.className.match(/\b(\d+)-column\b/)[1],
10);
> +	   }

I think it's a little overkill to add this inline function which is only used
once.