[webkit-reviews] review granted: [Bug 118946] fourthTier: It should be possible for a DFG::Node to claim to exit to one CodeOrigin, but then claim that it belongs to a different CodeOrigin for all other purposes : [Attachment 207212] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 118946: fourthTier: It should be possible for a DFG::Node to claim to exit
to one CodeOrigin, but then claim that it belongs to a different CodeOrigin for
all other purposes
https://bugs.webkit.org/show_bug.cgi?id=118946

Attachment 207212: the patch
https://bugs.webkit.org/attachment.cgi?id=207212&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207212&action=review


r=me

> Source/JavaScriptCore/dfg/DFGNode.h:1388
> +    // Code origin for profiling.
> +    CodeOrigin codeOriginForExitTarget;

The JIT does this:

 1712	     m_codeOriginForExitTarget =
m_currentNode->codeOriginForExitTarget;
 1713	     m_codeOriginForExitProfiling = m_currentNode->codeOrigin;

So, I don't think this comment that says codeOriginForExitTarget is used for
profiling is correct.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2875
> +    CodeOrigin m_codeOriginForExitProfile;

Can you pick either "ForExitProfile" or "ForExitProfiling", and use it
everywhere?