[webkit-reviews] review granted: [Bug 118941] Do not allocate 2 AtomicString just to do a comparison in HTMLAnchorElement::setRel() : [Attachment 207189] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 21 16:15:28 PDT 2013


Gavin Barraclough <barraclough at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 118941: Do not allocate 2 AtomicString just to do a comparison in
HTMLAnchorElement::setRel()
https://bugs.webkit.org/show_bug.cgi?id=118941

Attachment 207189: Patch
https://bugs.webkit.org/attachment.cgi?id=207189&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=207189&action=review


> Source/WebCore/dom/SpaceSplitString.h:91
> +	       return spaceSplitStringContainsValue(spaceSplitString, value,
length - 1, shouldFoldCase);

The -1 here wasn't obvious to me?


More information about the webkit-reviews mailing list