[webkit-reviews] review granted: [Bug 118873] Use explicit HTMLFrameElementBase cast : [Attachment 207045] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 18 21:47:27 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 118873: Use explicit HTMLFrameElementBase cast
https://bugs.webkit.org/show_bug.cgi?id=118873

Attachment 207045: Patch
https://bugs.webkit.org/attachment.cgi?id=207045&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207045&action=review


> Source/WebCore/rendering/RenderFrameBase.cpp:76
> -    HTMLFrameElementBase* element =
static_cast<HTMLFrameElementBase*>(node());
> +    HTMLFrameElementBase* element = toHTMLFrameElementBase(node());
>      bool isScrollable = element->scrollingMode() != ScrollbarAlwaysOff;

It seems like this local variable is used only once. You might as well as do:
toHTMLFrameElementBase(node())->scrollingMode() != ScrollbarAlwaysOff
instead.


More information about the webkit-reviews mailing list