[webkit-reviews] review denied: [Bug 118879] SerializedScriptValue should be ThreadSafeRefCounted when ENABLE(WORKERS) guard is on : [Attachment 207048] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 118879: SerializedScriptValue should be ThreadSafeRefCounted when
ENABLE(WORKERS) guard is on
https://bugs.webkit.org/show_bug.cgi?id=118879

Attachment 207048: Patch
https://bugs.webkit.org/attachment.cgi?id=207048&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207048&action=review


I don't see why this is necessary. But please feel free to mark for review
again with additional explanation.

> Source/WebCore/ChangeLog:10
> +	   SerializedScriptValue should be ThreadSafeRefCounted when
> +	   ENABLE(WORKERS) guard is on because WorkerMessagingProxy passes
> +	   SerializedScriptValue across threads.

I don't think that this is a sufficient explanation. An object only needs to be
ThreadSafeRefCounted if multiple threads reference/dereference it. But if
ownership is cleanly passed from one thread to another, that should not be
necessary.