[webkit-reviews] review granted: [Bug 118854] REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests : [Attachment 206997] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 18 10:54:19 PDT 2013
David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 118854: REGRESSION (r132678): Tests that use SSL or port 8080 time out when
run using old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=118854
Attachment 206997: Patch
https://bugs.webkit.org/attachment.cgi?id=206997&action=review
------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206997&action=review
r=me
> Tools/Scripts/old-run-webkit-tests:1586
> + "-c", "ErrorLog \"$absTestResultsDirectory/error_log.txt\""
Nit: I'm a fan of leaving the comma at the end in case more lines are added
later, but it's not required to land this.
More information about the webkit-reviews
mailing list