[webkit-reviews] review granted: [Bug 118851] Add extract-localizable-js-strings and use it for WebInspectorUI : [Attachment 206992] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 118851: Add extract-localizable-js-strings and use it for WebInspectorUI
https://bugs.webkit.org/show_bug.cgi?id=118851

Attachment 206992: Patch
https://bugs.webkit.org/attachment.cgi?id=206992&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206992&action=review


r=me

> Tools/Scripts/extract-localizable-js-strings:59
> +    $file =~ s-^./--;

I have never seen "-" used as the s/// delimiter. It is kind of confusing.
Typically I see / or | used.

Also, is this trying to detect a literal '.' or a single character directory?
Seems like this should be

    $file =~ s|^\./||;

> Tools/Scripts/extract-localizable-strings:46
> +no warnings 'deprecated';

Why is this needed and not needed before?

> Tools/Scripts/update-webkit-localizable-strings:42
> +my $webInspectorUIFileToUpdate =
"../OpenSource/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
";

I suspect the "../OpenSource/" part of this path should be removed.