[webkit-reviews] review denied: [Bug 74020] [CSS Regions] Absolutely positioned elements that span RTL regions of different widths are positioned incorrectly : [Attachment 206144] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Anton Obzhirov
<a.obzhirov at samsung.com>'s request for review:
Bug 74020: [CSS Regions] Absolutely positioned elements that span RTL regions
of different widths are positioned incorrectly
https://bugs.webkit.org/show_bug.cgi?id=74020

Attachment 206144: Patch
https://bugs.webkit.org/attachment.cgi?id=206144&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206144&action=review


> Source/WebCore/rendering/RenderBlock.cpp:1541
> +    LayoutUnit oldTop = logicalTop();
> +
> +    setLogicalHeight(LayoutUnit::max() / 2);
> +    updateLogicalHeight();

This seems wrong to me. I fail to see why the height would not be correct,
since we finished child layout and just before calling
updateRegionsAndShapesAfterChildLayout we even did updateLogicalHeight in
RenderBlock.

I think I'm going to need more detail before I'm going to believe this should
be necessary.