[webkit-reviews] review denied: [Bug 118584] [Application Cache] Assert failed if ApplicationCacheStorage::setCacheDirectory is called more than once. : [Attachment 206508] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Donggwan Kim
<donggwan.kim at samsung.com>'s request for review:
Bug 118584: [Application Cache] Assert failed if
ApplicationCacheStorage::setCacheDirectory is called more than once.
https://bugs.webkit.org/show_bug.cgi?id=118584

Attachment 206508: Patch
https://bugs.webkit.org/attachment.cgi?id=206508&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
If we are to allow changing directory on the fly, then we should ensure that
on-disk database state doesn't get out of sync. So, we should either close it
and open one from the new directory, or make this function assert when called
in a situation where safe change is not possible.