[webkit-reviews] review granted: [Bug 118682] HTMLMediaElement should not add cues for disabled text tracks : [Attachment 206682] Proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 118682: HTMLMediaElement should not add cues for disabled text tracks
https://bugs.webkit.org/show_bug.cgi?id=118682

Attachment 206682: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=206682&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206682&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:1490
> -void HTMLMediaElement::textTrackAddCues(TextTrack*, const TextTrackCueList*
cues) 
> +void HTMLMediaElement::textTrackAddCues(TextTrack* track, const
TextTrackCueList* cues) 

Would it make sense for this function to take PassRefPtr<TextTrack> instead to
be safe?