[webkit-reviews] review granted: [Bug 118690] PluginProcess deny file-read-data /Library/Application Support/Macromedia/FlashPlayerTrust : [Attachment 206690] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 118690: PluginProcess deny file-read-data /Library/Application
Support/Macromedia/FlashPlayerTrust
https://bugs.webkit.org/show_bug.cgi?id=118690

Attachment 206690: Patch
https://bugs.webkit.org/attachment.cgi?id=206690&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206690&action=review


> Source/WebKit2/Resources/PlugInSandboxProfiles/com.macromedia.Flash
Player.plugin.sb:40
> +	 (literal "Library/Application Support/Macromedia/FlashPlayerTrust")

This is not a proper path, there should be a slash before "Library".

I'd block "subpath", not "literal" - we are not interested in further
violations inside this path even if Flash goes there.

Also, four space indentation please.