[webkit-reviews] review requested: [Bug 118498] ASSERTION FAILED: callFrame == vm->topCallFrame || callFrame == callFrame->lexicalGlobalObject()->globalExec() || callFrame == callFrame->dynamicGlobalObject()->globalExec() in JSC::Interpreter::addStackTraceIfNecessary : [Attachment 206473] patch with functors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 11 09:47:13 PDT 2013


Chris <chris_curtis at apple.com> has asked  for review:
Bug 118498: ASSERTION FAILED: callFrame == vm->topCallFrame || callFrame ==
callFrame->lexicalGlobalObject()->globalExec() || callFrame ==
callFrame->dynamicGlobalObject()->globalExec() in
JSC::Interpreter::addStackTraceIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=118498

Attachment 206473: patch with functors
https://bugs.webkit.org/attachment.cgi?id=206473&action=review

------- Additional Comments from Chris <chris_curtis at apple.com>
The patch with functors. Something to note, This does not address separate
stack overflow issue which creates the stack trace each time. The test cases
right now will time out when running correctly and crash when it fails. I have
not looked into this too much yet, but Oliver mentioned it possibly had
something to do with toStringSlowCase. Should that be addressed in this patch
as well or in a new bug?


More information about the webkit-reviews mailing list