[webkit-reviews] review denied: [Bug 118568] [WK2][UNIX] Free standard output obtained from g_spawn_sync() with g_free : [Attachment 206471] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Sergio Correia
<sergio.correia at openbossa.org>'s request for review:
Bug 118568: [WK2][UNIX] Free standard output obtained from g_spawn_sync() with
g_free
https://bugs.webkit.org/show_bug.cgi?id=118568

Attachment 206471: Patch
https://bugs.webkit.org/attachment.cgi?id=206471&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206471&action=review


I'm not sure that g_free is necessarily better than free, but a GOwnptr
probably makes sense. :)

> Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:73
> -    char* stdOut = 0;
> +    gchar* stdOut = 0;

Why is this necessary? They are the same type and in WebKit code we typically
use the non-Glib versions.

> Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:91
> +	   g_free(stdOut);

Why not switch to using GOwnPtr here?