[webkit-reviews] review granted: [Bug 118358] Nix upstreaming - Adding stubs and Nix specific platform files : [Attachment 206410] New patch without glib directory.

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Luciano Wolf
<luciano.wolf at openbossa.org>'s request for review:
Bug 118358: Nix upstreaming - Adding stubs and Nix specific platform files
https://bugs.webkit.org/show_bug.cgi?id=118358

Attachment 206410: New patch without glib directory.
https://bugs.webkit.org/attachment.cgi?id=206410&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206410&action=review


> Source/WebCore/platform/nix/LanguageNix.cpp:44
> +	   return String("c");

String("c") -> ASCIIString("c")

> Source/WebCore/platform/nix/NixKeyboardUtilities.h:34
> +namespace WTF {
> +class String;
> +}

WTF::String is not used in this header.