[webkit-reviews] review granted: [Bug 116853] ASSERTION FAILED: low in JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset : [Attachment 206419] patch 2

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 116853: ASSERTION FAILED: low in
JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset
https://bugs.webkit.org/show_bug.cgi?id=116853

Attachment 206419: patch 2
https://bugs.webkit.org/attachment.cgi?id=206419&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206419&action=review


r=me, but i want to know why you have made the change to
BinaryOpNode::emitBytecode -- i can't see why it would be necessary and it
would have  a significant memory impact

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1099
> +    generator.emitExpressionInfo(startOffset(), 0, 0, lineNo(),
lineStartOffset());

Why is this necessary?