[webkit-reviews] review granted: [Bug 116817] [GStreamer] support preload="metadata" : [Attachment 205999] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 116817: [GStreamer] support preload="metadata"
https://bugs.webkit.org/show_bug.cgi?id=116817

Attachment 205999: Patch
https://bugs.webkit.org/attachment.cgi?id=205999&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205999&action=review


>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1523

> +    bool shouldDownload = !isLiveStream() && m_preload == MediaPlayer::Auto;

>      if (shouldDownload) {

Do you really want to clear the GST_PLAY_FLAG_DOWNLOAD flag when m_preload
changes from "auto" to "metadata" or "none" (eg. after downloading has already
started)?